Add inverse breadcrumb and back link modifiers and styles #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Does the job. Tested by applying the class and adding a black background locally.
You make a good point on not being able to see examples of this in the review app and I think we can get around this relatively easily by updating the showExamples macro. I'll put an issue together.
|
An extra comment: I wonder if we should keep the linked issue open after this gets merged for 2 reasons:
|
|
Good points, I've removed the closing comment. |
3 tasks
2 tasks
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jun 25, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jun 25, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jun 25, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jul 8, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jul 8, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jul 8, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
Jul 8, 2023
Support was recently added for inverse breadcrumbs[0]. Like the recent inverse button change[1] we're using the `inverse` keyword arg to allow the mode to be toggled. Refs #428 [0] #418 [1] alphagov/govuk-frontend#3774
colinrotherham
pushed a commit
that referenced
this pull request
Jul 19, 2023
…inks Add inverse breadcrumb and back link modifiers and styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because everyone loves a small story.
Adds inverted colour scheme variants of the Breadcrumb and Back Link components, for use on darker backgrounds, as is used on product landing pages and some sections of GOV.UK.
Related to #2266.
Thoughts