Refactor mobile menu button label/text handling #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
approved these changes
Jun 12, 2023
colinrotherham
pushed a commit
that referenced
this pull request
Jul 19, 2023
Refactor mobile menu button label/text handling
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent DAC audit of Frontend flagged that we do not need to
aria-labelthe Header component's mobile navigation toggle as "Show or hide menu", as the presence of thearia-expandedattribute already indicates that the button performs a showing and hiding action, as well as what the current expanded status is.We could simply change the default
aria-labelto be 'Menu', however the label would then be identical to the default inner text of the button—which is redundant.This PR makes it so that the button's
aria-labelattribute is only set if it's been explicitly defined (rather than having a default), and if the label text is different to the inner text of the button.Resolves #3696.