Add ability to customise inverse button colours #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
force-pushed
the
inverse-button-improvements
branch
from
866240a
to
f4a74b3
Compare
|
@owenatgov Can I get a quick reckon on whether this should be put down as a breaking change or not? |
|
@querkmachine So, based on your reasoning I reckon lets be cautious and call it a breaking change. We want teams to check that it's not going to impact their buttons, even if it's unlikely. |
querkmachine
force-pushed
the
inverse-button-improvements
branch
from
f4a74b3
to
6b7178e
Compare
querkmachine
force-pushed
the
inverse-button-improvements
branch
from
6b7178e
to
c14f2c5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "quick-fix" for the inverse button styles using hardcoded blue text and hover colours, where non-GOV.UK branded services probably want this to match the
$govuk-brand-colourvariable.Related to #3918. Extracted from PR #3925, which includes more significant changes covering all inverse components.
Changes
$govuk-inverse-button-background-colour, which defaults togovuk-colour("white").$govuk-inverse-button-text-colour, which defaults to$govuk-brand-colour.govuk-colour("blue"). This will look the same if the brand colour has not been changed, but will be different if it has.