Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw ElementError when "Exit this page" button is missing #4199

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Sep 11, 2023

Wording to match that of the Skip link component, but to be reviewed in #4072. Wording is now handled by the ElementError class and will match the other ElementError being thrown.

Closes #4129

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4199 September 11, 2023 11:50 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4199 September 11, 2023 11:51 Inactive
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 75.73 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 71.14 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 36.88 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 67.24 KiB
components/accordion/accordion.mjs 21.78 KiB
components/button/button.mjs 4.58 KiB
components/character-count/character-count.mjs 21.52 KiB
components/checkboxes/checkboxes.mjs 5.28 KiB
components/error-summary/error-summary.mjs 5.88 KiB
components/exit-this-page/exit-this-page.mjs 16.47 KiB
components/header/header.mjs 3.21 KiB
components/notification-banner/notification-banner.mjs 4.42 KiB
components/radios/radios.mjs 4.29 KiB
components/skip-link/skip-link.mjs 3.63 KiB
components/tabs/tabs.mjs 8.95 KiB

View stats and visualisations on the review app


Action run for 26a179a

renderAndInitialise(page, 'exit-this-page', {
params: examples.default,
beforeInitialisation($module) {
$module.querySelector('.govuk-exit-this-page__button').remove()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4199 September 12, 2023 11:28 Inactive
@romaricpascal romaricpascal changed the base branch from main to components-type-error September 12, 2023 11:28
@romaricpascal romaricpascal changed the title Throw MissingElementError when "Exit this page" button is missing Throw ElementError when "Exit this page" button is missing Sep 12, 2023
@colinrotherham colinrotherham force-pushed the components-type-error branch 2 times, most recently from 090e1b6 to 655af8f Compare September 18, 2023 13:29
Base automatically changed from components-type-error to main September 18, 2023 14:27
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4199 September 18, 2023 15:01 Inactive
@romaricpascal romaricpascal merged commit d149281 into main Sep 18, 2023
44 checks passed
@romaricpascal romaricpascal deleted the exit-this-page-missing-element branch September 18, 2023 16:14
@romaricpascal romaricpascal mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw errors during Exit This Page initialisation if key HTML elements are missing
3 participants