Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prose scope example #429

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Add prose scope example #429

merged 1 commit into from
Jan 12, 2018

Conversation

36degrees
Copy link
Member

Add an example of the prose scope being applied to some example HTML so that contributors can understand how their changes to Frontend might affect it.

https://trello.com/c/Jtron4KD/574-add-prose-scope-example

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-429 January 12, 2018 12:23 Inactive
@joelanman
Copy link
Contributor

@amyhupe and I had a discussion previously about sample content. It's a bit tricky using real guidance, as it can easily get out of date. One solution we thought of was using 'historical' content that is much less likely to change, say an announcement. Alternatively just ipsum lorem

@36degrees
Copy link
Member Author

This is exactly the same content as we currently have in one of the typography examples, so this isn't introducing anything new. Agree that we should review what content we're using generally, but I don't think we need to address it as part of this PR.

@joelanman
Copy link
Contributor

ah ok, good point. However, this sample doesn't cover uls and ols, which is provided by prose-scope - do we want a sample that will cover that? The sample in the design system is here:

https://govuk-design-system-production.cloudapps.digital/styles/typography/prose-scope/index.html

@36degrees
Copy link
Member Author

Good call, will update.

@36degrees
Copy link
Member Author

@joelanman have updated with a new example based on the example in the design system, but with headings directly following each other, an example of a longer list item and a few links.

@joelanman joelanman self-requested a review January 12, 2018 16:44
Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@36degrees 36degrees merged commit 4130801 into master Jan 12, 2018
@36degrees 36degrees deleted the add-prose-scope-example branch January 12, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants