Update descriptions for Nunjucks macro options + fixes

[colinrotherham]

Adds new descriptions from alphagov/govuk-design-system#2929 (comment)

[github-actions]

📋 Stats

File sizes

File	Size
dist/govuk-frontend-5.0.0-beta.1.min.css	114 KiB
dist/govuk-frontend-5.0.0-beta.1.min.js	37.93 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js	77.58 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs	72.89 KiB
packages/govuk-frontend/dist/govuk/all.mjs	3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs	359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css	113.53 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js	38.11 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs	5.38 KiB

Modules

File	Size
all.mjs	69.22 KiB
components/accordion/accordion.mjs	21.47 KiB
components/button/button.mjs	4.5 KiB
components/character-count/character-count.mjs	21.05 KiB
components/checkboxes/checkboxes.mjs	5.63 KiB
components/error-summary/error-summary.mjs	5.89 KiB
components/exit-this-page/exit-this-page.mjs	15.89 KiB
components/header/header.mjs	3.71 KiB
components/notification-banner/notification-banner.mjs	4.34 KiB
components/radios/radios.mjs	4.63 KiB
components/skip-link/skip-link.mjs	3.61 KiB
components/tabs/tabs.mjs	9.47 KiB

View stats and visualisations on the review app

---

Action run for 8113c4f

[colinrotherham]

Mind taking a look at some suggestions of mine please @CharlotteDowns?

Mainly to swap "Can be used to add a…" with "Additional options for…" when defaults are already provided

My fault for not including fieldset in alphagov/govuk-design-system#2929 (comment) (or nested hint and label for checkboxes and radios) but I've added them, can always keep tweaking

[CharlotteDowns]

Looks good to me

[colinrotherham]

@36degrees Shall we add in some of your suggestions from #3919 before merging this?

One of them was moving the "this is not required" text to the end:

- description: If `text` is set, this is not required. The heading HTML content of each section. The header is inside the HTML `<button>` element, so you can only add [phrasing content](https://html.spec.whatwg.org/#phrasing-content) to it. If `html` is provided, the `text` option will be ignored.
+ description: The heading HTML content of each section. The header is inside the HTML `<button>` element, so you can only add [phrasing content](https://html.spec.whatwg.org/#phrasing-content) to it. If `html` is provided, the `text` option will be ignored. If `text` is provided, this is not required.

[36degrees]

This generally looks like a great improvement, but there are a few places where there are a few inaccuracies – a few of them are existing issues.

There's also a few places where we've aligned the description to the name of the option (like talking about 'items' more) but in doing so made it less useful in terms of explaining what items actually means.

[colinrotherham]

@36degrees I've pushed up all those great suggestions

Not urgent, but we jump between "The thing" versus "Thing" which we could tackle at some point:

• description: Name attribute…
• description: The name attribute…
• description: The name attribute…

Possibly made worse now we're (mostly) code-wrapping attribute names, values etc

[colinrotherham]

Thanks @36degrees for all the comments, this is ready to review now

• See commit 849cacb to remove “Additional options for…” from mandatory params
• See commit 8113c4f with added “Can be used to…” to more optional nested components

[36degrees]

Some really nice improvements here, thanks @colinrotherham and @CharlotteDowns! 👏🏻