-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header product name wrapping onto new line #4498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for a705245 |
47ba6dc
to
653bd38
Compare
Stylesheets changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
index 156badbe0..c00459365 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
@@ -3890,6 +3890,12 @@ only screen and (min-resolution:2dppx) {
vertical-align: top
}
+ .govuk-header__logo:last-child {
+ width: auto;
+ padding-right: 0;
+ float: none
+ }
+
.govuk-header__content {
width: 66.66%;
padding-left: 15px;
Action run for a705245 |
JavaScript changes to npm packageNo changes found. Action run for a705245 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/header/_index.scss b/packages/govuk-frontend/dist/govuk/components/header/_index.scss
index fa80fbdcb..08865369e 100644
--- a/packages/govuk-frontend/dist/govuk/components/header/_index.scss
+++ b/packages/govuk-frontend/dist/govuk/components/header/_index.scss
@@ -168,6 +168,13 @@
padding-right: $govuk-gutter-half;
float: left;
vertical-align: top;
+
+ // Reset float when logo is the last child, without a navigation
+ &:last-child {
+ width: auto;
+ padding-right: 0;
+ float: none;
+ }
}
}
Action run for a705245 |
1a8bc72
to
c03040d
Compare
653bd38
to
89dfdc0
Compare
c03040d
to
048d4e6
Compare
89dfdc0
to
62213dc
Compare
048d4e6
to
8037858
Compare
62213dc
to
600faa4
Compare
8037858
to
45fa227
Compare
600faa4
to
5b46748
Compare
45fa227
to
e53d6e9
Compare
5b46748
to
fe6a196
Compare
f514d76
to
1bca0a6
Compare
fe6a196
to
e3c3f37
Compare
1bca0a6
to
20ea8cc
Compare
e3c3f37
to
6f65dfc
Compare
20ea8cc
to
94b5086
Compare
6f65dfc
to
302638d
Compare
94b5086
to
d93603d
Compare
302638d
to
1d342dd
Compare
1d342dd
to
a705245
Compare
This was referenced Dec 1, 2023
romaricpascal
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples look fine on the review app 🙌🏻 ⛵
owenatgov
pushed a commit
that referenced
this pull request
Jan 11, 2024
Fix header product name wrapping onto new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1502
See the "Service Manual" topic page for an updated example:
https://govuk-frontend-pr-4498.herokuapp.com/full-page-examples/service-manual-topic
Before
We float the logo and apply
width: 33.33%
After
When the logo matches
:last-child
(no navigation or service name) we can reset the float