Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing for nested lists #464

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Add spacing for nested lists #464

merged 1 commit into from
Jan 25, 2018

Conversation

hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Jan 25, 2018

This PR:

  • Add top margin for lists within lists
  • Adds an example to frontend app
  • Updates changelog

To review, view: /examples/typography

Trello card: https://trello.com/c/vuqWoun4/517-spacing-for-nested-lists-to-be-added-to-frontend

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-464 January 25, 2018 10:58 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-464 January 25, 2018 11:00 Inactive
@NickColley
Copy link
Contributor

In your example this seems to put a margin-top of 10px on the root level component, instead of just the nested lists, is this intended?

@NickColley
Copy link
Contributor

screen shot 2018-01-25 at 11 05 10

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-464 January 25, 2018 11:06 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-464 January 25, 2018 11:13 Inactive
@hannalaakso
Copy link
Member Author

Good catch, not intended. Fixed now.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-464 January 25, 2018 11:16 Inactive
@NickColley
Copy link
Contributor

In your amended commit, does this now only work for .govuk-list usage and not .govuk-prose?

Also add example to typography and prose scope in review app. Update changelog.
@hannalaakso
Copy link
Member Author

This should work for .govuk-list and for lists within .govuk-prose-scope. I've just added an example to /examples/prose-scope

@NickColley
Copy link
Contributor

Sweet 👍

If anyone else is interested it gets mixed in here:

@hannalaakso hannalaakso merged commit 06f60eb into master Jan 25, 2018
@hannalaakso hannalaakso deleted the margin-multi-lists branch January 25, 2018 13:22
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants