Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate element parameter on button component #4646

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

querkmachine
Copy link
Member

As per #4168, mark the element parameter as deprecated in the Nunjucks parameter docs and in the changelog.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4646 January 15, 2024 16:12 Inactive
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.45 KiB
dist/govuk-frontend-development.min.js 38.58 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.74 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.99 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.44 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.57 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 70.32 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.57 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 4.46 KiB
components/notification-banner/notification-banner.mjs 4.93 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.39 KiB
components/tabs/tabs.mjs 10.16 KiB

View stats and visualisations on the review app


Action run for fd1c723

Copy link

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/components/button/macro-options.json b/packages/govuk-frontend/dist/govuk/components/button/macro-options.json
index b3f6f6461..d922bbaa1 100644
--- a/packages/govuk-frontend/dist/govuk/components/button/macro-options.json
+++ b/packages/govuk-frontend/dist/govuk/components/button/macro-options.json
@@ -3,7 +3,7 @@
         "name": "element",
         "type": "string",
         "required": false,
-        "description": "HTML element for the button component – `input`, `button` or `a`. In most cases you will not need to set this as it will be configured automatically if `href` is provided."
+        "description": "HTML element for the button component – `input`, `button` or `a`. In most cases you will not need to set this as it will be configured automatically if `href` is provided. This parameter will be removed in the next major version."
     },
     {
         "name": "text",

Action run for fd1c723

@querkmachine querkmachine requested a review from a team January 15, 2024 16:20
@querkmachine querkmachine marked this pull request as ready for review January 15, 2024 16:20
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job!

@querkmachine querkmachine linked an issue Jan 15, 2024 that may be closed by this pull request
3 tasks
@querkmachine querkmachine merged commit ed027b8 into main Jan 15, 2024
45 checks passed
@querkmachine querkmachine deleted the deprecate-button-element branch January 15, 2024 16:40
@querkmachine querkmachine mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the element option for the govukButton macro
3 participants