Add tests for error summary component #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests to test macro output
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-489
kr8n3r
force-pushed
the
tests-for-error-summary
branch
from
0803d4c
to
24169b7
Compare
alex-ju
approved these changes
Feb 1, 2018
|
|
||
| it('allows description text to be passed whilst escaping HTML entities', () => { | ||
| const { $ } = render('error-summary', { | ||
| descriptionText: 'See errors below (▼)' |
36degrees
reviewed
Feb 2, 2018
| }) | ||
|
|
||
| const $component = $('.govuk-c-error-summary') | ||
| expect($component.hasClass('extra-class one-more-class')).toBeTruthy() |
There was a problem hiding this comment.
I am surprised this works - it seems to go against Cheerio and jQuery's documentation which both expect a single class to be passed. Wouldn't be surprised if this is a bug in Cheerio…
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Trello Card: https://trello.com/c/1PnIu9nh/644-automated-tests-for-error-summary-component