[SPIKE] Navigation - create navigation component #4908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
4 tasks
|
@domoscargin I'm so glad you brought this up:
I'm not sure I like this about it if I'm honest, I'm drafting some potential designs in the [Navigation spikes doc] to help (https://docs.google.com/document/d/1XUgtfGpnEWXjWBqouZs2FYDZrGHhhr1KPxoT68poHDA/edit#heading=h.6y0801gjvd5q) |
govuk-design-system-ci
had a problem deploying
to
govuk-frontend-pr-4908
This comment was marked as off-topic.
This comment was marked as off-topic.
govuk-design-system-ci
had a problem deploying
to
govuk-frontend-pr-4908
domoscargin
force-pushed
the
bk-spike-nav-component
branch
from
0e982b6
to
8944cbb
Compare
govuk-design-system-ci
had a problem deploying
to
govuk-frontend-pr-4908
domoscargin
force-pushed
the
bk-spike-nav-component
branch
from
8944cbb
to
13efac5
Compare
|
Closing in favour of #4915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a navigation component to govuk-frontend, wholesale copied from the One Login header, then tweaked slightly.
It's a foundation to investigate alphagov/govuk-design-system#3715
See the thing here: https://govuk-frontend-pr-4908.herokuapp.com/components/navigation