Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canvas colour for cookie banner over hardcoded grey #4919

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Use canvas colour for cookie banner over hardcoded grey #4919

merged 2 commits into from
Apr 3, 2024

Commits on Apr 3, 2024

  1. Use canvas colour for cookie banner over hardcoded grey 

    The cookie banner is hardcoded to use light-grey as a background colour. Wherever possible, we should use the ‘applied’ colours rather than specific colours from the palette.

We think (although this is somewhat post-rationalising) that the cookie banner uses light-grey for the same reason the footer does. Light grey is the 'canvas' colour used for the `<html>` element and everything outside of the <body>, including any viewport after the footer and the overscroll area. As the cookie banner appears above the header, it's conceptually outside of the body of the page.

Update the cookie banner to reference the canvas background colour rather than the hardcoded light-grey.
    @36degrees
    36degrees committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    98d65b1 View commit details
    Browse the repository at this point in the history

  2. Document in CHANGELOG

    @36degrees
    36degrees committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5c7ce04 View commit details
    Browse the repository at this point in the history