Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: dark mode palette #4931

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@include govuk-exports("govuk/component/accordion") {
$govuk-accordion-base-colour: govuk-colour("black");
$govuk-accordion-hover-colour: govuk-colour("light-grey");
$govuk-accordion-base-colour: govuk-colour("white");
$govuk-accordion-hover-colour: govuk-colour("black");
$govuk-accordion-icon-focus-colour: $govuk-focus-colour;
$govuk-accordion-bottom-border-width: 1px;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
///
/// @type Colour
/// @access public
///
/// Same green as govuk-success-colour

$govuk-button-background-colour: govuk-colour("green") !default;
$govuk-button-background-colour: #00a357 !default;

/// Button component text colour
///
Expand All @@ -34,7 +36,7 @@ $govuk-inverse-button-text-colour: $govuk-brand-colour !default;
$govuk-button-colour: $govuk-button-background-colour;
$govuk-button-text-colour: $govuk-button-text-colour;
$govuk-button-hover-colour: govuk-shade($govuk-button-colour, 20%);
$govuk-button-shadow-colour: govuk-shade($govuk-button-colour, 60%);
$govuk-button-shadow-colour: govuk-shade($govuk-button-colour, 40%);

// Secondary button variables
$govuk-secondary-button-colour: govuk-colour("light-grey");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

// Visually separate the cookie banner from content underneath
// when user changes colours in their browser.
border-bottom: $border-bottom-width solid transparent;
border-bottom: 1px solid $govuk-border-colour;

background-color: $govuk-canvas-background-colour;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// https://bugs.webkit.org/show_bug.cgi?id=224746
&::-webkit-file-upload-button {
-webkit-appearance: button;
color: inherit;
color: govuk-colour("black");
font: inherit;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
.govuk-header {
@include govuk-font($size: 16, $line-height: 1);

border-bottom: govuk-spacing(2) solid govuk-colour("white");
border-bottom: govuk-spacing(2) solid $govuk-body-background-colour;
color: $govuk-header-text;
background: $govuk-header-background;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
padding: govuk-spacing(1);
// setting any background-color makes text invisible when changing colours to dark backgrounds in Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1335476)
// as background-color and color need to always be set together, color should not be set either
border: $govuk-border-width-form-element solid $govuk-input-border-colour;
border: $govuk-border-width-form-element solid govuk-colour("white");
border-radius: 0;
color: $govuk-text-colour;
background-color: $govuk-body-background-colour;

// Disable inner shadow and remove rounded corners
appearance: none;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
float: left; // Float is ignored if flex is active for prev/next links

&:hover {
background-color: govuk-colour("light-grey");
background-color: govuk-colour("black");
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// Default user agent colours for selects can have low contrast,
// and may look disabled (#2435)
color: $govuk-text-colour;
background-color: govuk-colour("white");
background-color: $govuk-body-background-colour;

&:focus {
outline: $govuk-focus-width solid $govuk-focus-colour;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
padding: govuk-spacing(2) govuk-spacing(4);

float: left;
background-color: govuk-colour("light-grey");
background-color: $govuk-canvas-background-colour;
text-align: center;

&::before {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import "../tag/index";

@include govuk-exports("govuk/component/task-list") {
$govuk-task-list-hover-colour: govuk-colour("light-grey");
$govuk-task-list-hover-colour: govuk-colour("black");

.govuk-task-list {
@include govuk-font($size: 19);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
border: $govuk-border-width-form-element solid $govuk-input-border-colour;
border-radius: 0;

color: $govuk-text-colour;
background-color: $govuk-body-background-colour;

-webkit-appearance: none;

&:focus {
Expand Down
26 changes: 15 additions & 11 deletions packages/govuk-frontend/src/govuk/settings/_colours-applied.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $govuk-brand-colour: govuk-colour("blue") !default;
/// @type Colour
/// @access public

$govuk-text-colour: govuk-colour("black") !default;
$govuk-text-colour: #ffffff !default;

/// Canvas background colour
///
Expand All @@ -30,14 +30,14 @@ $govuk-text-colour: govuk-colour("black") !default;
/// @type Colour
/// @access public

$govuk-canvas-background-colour: govuk-colour("light-grey") !default;
$govuk-canvas-background-colour: #263136 !default;

/// Body background colour
///
/// @type Colour
/// @access public

$govuk-body-background-colour: govuk-colour("white") !default;
$govuk-body-background-colour: #1e1f21 !default;

/// Text colour for print media
///
Expand All @@ -55,7 +55,7 @@ $govuk-print-text-colour: #000000 !default;
/// @type Colour
/// @access public

$govuk-secondary-text-colour: govuk-colour("dark-grey") !default;
$govuk-secondary-text-colour: #cccccc !default;

/// Focus colour
///
Expand Down Expand Up @@ -83,17 +83,21 @@ $govuk-focus-text-colour: govuk-colour("black") !default;
///
/// @type Colour
/// @access public
///
/// Increased the luminance of existing red until it reached 5:1 contrast

$govuk-error-colour: govuk-colour("red") !default;
$govuk-error-colour: #e96753 !default;

/// Success colour
///
/// Used to highlight success messages and banners
///
/// @type Colour
/// @access public
///
/// Increased the luminance of existing green until it reached 5:1 contrast

$govuk-success-colour: govuk-colour("green") !default;
$govuk-success-colour: #00a357 !default;

/// Border colour
///
Expand All @@ -111,7 +115,7 @@ $govuk-border-colour: govuk-colour("mid-grey") !default;
/// @type Colour
/// @access public

$govuk-input-border-colour: govuk-colour("black") !default;
$govuk-input-border-colour: govuk-colour("white") !default;

/// Input hover colour
///
Expand All @@ -131,25 +135,25 @@ $govuk-hover-colour: govuk-colour("mid-grey") !default;
/// @type Colour
/// @access public

$govuk-link-colour: govuk-colour("blue") !default;
$govuk-link-colour: #3892e0 !default;

/// Visited link colour
///
/// @type Colour
/// @access public

$govuk-link-visited-colour: govuk-colour("purple") !default;
$govuk-link-visited-colour: #9d80db !default;

/// Link hover colour
///
/// @type Colour
/// @access public

$govuk-link-hover-colour: govuk-colour("dark-blue") !default;
$govuk-link-hover-colour: #5ca5e6 !default;

/// Active link colour
///
/// @type Colour
/// @access public

$govuk-link-active-colour: govuk-colour("black") !default;
$govuk-link-active-colour: govuk-colour("white") !default;
Loading