Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use govuk-text-colour mixin for fieldset #544

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

36degrees
Copy link
Member

This ensures that the fieldset gets the correct behaviour associated with other text-coloured elements. For example, at the minute print media uses ‘full black’ (#000) for other text colour elements, and this is not being applied here.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-544 February 23, 2018 11:58 Inactive
This ensures that the fieldset gets the correct behaviour associated with other text-coloured elements. For example, at the minute print media uses ‘full black’ (#000) for other text colour elements, and this is not being applied here.
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@36degrees 36degrees merged commit 834c706 into master Feb 23, 2018
@36degrees 36degrees deleted the fieldset-use-text-colour-mixin branch February 23, 2018 13:49
This was referenced Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants