Fix inline radios #607
Merged
Fix inline radios #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-607
|
CH CH CH CHANGELOG :) sorry :( |
Introduce a modifier at the block level which makes all radios within that block inline. You can’t add classes to the individual radio items using the macro, and it doesn’t really make sense to require the modifier to be applied to every individual element. Add an example of inline radios so that they are represented in the review app. Update the readme.
36degrees
force-pushed
the
fix-inline-radios
branch
from
03baa44
to
db879d7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-607
|
Updated. 🎵Just gonna have to be a different man |
|
Sorry @igloosi – one more commit to check. |
|
it's good, though i feel like using inline radios is when you have shortly worded selection which should fit side-by-side on mobile. |
|
Don't disagree, but from talking to @dashouse I think matching the existing behaviour in Elements is the right thing to do for now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we do actually have a style for inline radios, it's just not documented or easy to apply. (h/t to @dashouse for spotting this…)
Introduce a modifier at the block level which makes all radios within that block inline. You can’t add classes to the individual radio items using the macro, and it doesn’t really make sense to require the modifier to be applied to every individual element.
Add an example of inline radios so that they are represented in the review app.
Update the readme.