Make Sass imports less broad #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-617
|
Seems fine to me, the main problem is that we were importing files that output CSS. So could solve this by chunking the imports better too. |
kr8n3r
force-pushed
the
make-sass-imports-less-broad
branch
from
3af484d
to
9d6282a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-617
kr8n3r
force-pushed
the
make-sass-imports-less-broad
branch
from
9d6282a
to
edb0de5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-617
kr8n3r
force-pushed
the
make-sass-imports-less-broad
branch
from
edb0de5
to
32334d4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-617
kr8n3r
force-pushed
the
make-sass-imports-less-broad
branch
from
32334d4
to
e3e28c8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-617
added 18 commits
March 28, 2018 13:59
kr8n3r
force-pushed
the
make-sass-imports-less-broad
branch
from
e3e28c8
to
73ea204
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
globals/commonimport in each component with only the necessary partials.There is already a test that checks if individual component Sass files compile.
Note: i've placed typography partials at the end of imports to make it a bit easier to do the work of making typography imports conditional.
https://trello.com/c/unO51Rno/830-make-sass-imports-dependencies-less-broad