Modules with rollup #652
Merged
Modules with rollup #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-652
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-652
|
changelog! |
|
this is much more understandable than webpack stuff. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-652
Follows the FT's Polyfill.io format, we may be able to make use of their upcoming npm library. Also refactors JavaScript linting since polyfills are techincally vendored files.
Rewrote the logic to avoid the issue, since we only care about the top level directories anyway. Allows us to remove a dependency in the process
alex-ju
force-pushed
the
modules-with-rollup
branch
from
41728e3
to
55a96d3
Compare
|
Thanks for the review @igloosi. Rebased for the changelog. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work replaces an attempt to use Webpack before running into issues with IE8.
Main changes
We now use ES6 modules to structure our code
We now ship UMD bundles which work with module bundlers and in browsers
We now have polyfills for 'bind' which uses an approach that mirrors the FT's Polyfill.io service
We removed the redundant
gulp-standardusageReverted Webpack work: Revert "Add Webpack as js bundler" #646
Attempt at IE8 support: https://github.com/alphagov/govuk-frontend/tree/ie8-webpack-support
See testing done in #646 as the main changes to the existing code has not changed.
Additional testing in IE8 has been done for this PR.
We intend to write up the findings from the Webpack work as documentation.