Vendor-in SassMQ functionality, write tests and remove external dependency #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
kr8n3r
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
|
Not great to vendor but I imagine we won't really need to update this, so seems good to me. Would be good to include a comment in the file that explains it's vendored, and what version it is based on. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
|
added the comment about where its vendored from and version |
NickColley
reviewed
Apr 17, 2018
| // the current breakpoint from being included multiple times. | ||
| // | ||
| // the current breakpoint from being included multiple times. | ||
| // | ||
| // We can't use the `exports` mixin for this because import directives cannot be |
There was a problem hiding this comment.
Non-blocking but if we vendor this is this hack necessary any more? @36degrees
There was a problem hiding this comment.
No, not if we wrap the whole of sass-mq in an exports.
36degrees
reviewed
Apr 17, 2018
| // the current breakpoint from being included multiple times. | ||
| // | ||
| // the current breakpoint from being included multiple times. | ||
| // | ||
| // We can't use the `exports` mixin for this because import directives cannot be |
There was a problem hiding this comment.
No, not if we wrap the whole of sass-mq in an exports.
| @@ -11,6 +11,6 @@ $sass-mq-already-included: false !default; | |||
| $mq-show-breakpoints: (); | |||
| } | |||
|
|
|||
| @import "./node_modules/sass-mq/mq"; | |||
| @import "../tools/sass-mq"; | |||
There was a problem hiding this comment.
It seems unnecessary to split media queries across these two layers… and because sass-mq 'outputs' CSS (even if it is just breakpoints) it would make more sense in here. Would suggest just moving sass-mq in here and using exports to simplify the hack as @NickColley identified.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-657
|
updated with comments by @NickColley and @36degrees |
added 5 commits
April 18, 2018 09:55
There are a number of scenarios where assuming the sass-mq dependency lives in the same project breaks that have been outlined in #636. As Sass does not allow dynamic imports we cannot provide a variable to override path to sass-mq stylesheet. To fix this and avoid external dependencies of Frontend, we've moved the functionality into the project.
NickColley
approved these changes
Apr 19, 2018
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of scenarios where assuming the sass-mq dependency lives in the same project breaks that have been outlined in #636.
As Sass does not allow dynamic imports we cannot provide a variable to override path to sass-mq stylesheet.
To fix this and avoid external dependencies of Frontend, we've moved the functionality into the project, wrote tests for its mixins and functions and remove dependency from package.json