Exclude test files and snapshots folders from copy task #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-662
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-662
NickColley
previously requested changes
Apr 18, 2018
NickColley
dismissed
their stale review
I don't think this is related to the incident, my mistake sorry.
added 2 commits
April 19, 2018 09:04
Currently tests that run after copy to `packages` or `dist` throw the following error: ``` 10 obsolete snapshot files found, run npm run test:build:packages -- -u to remove them.. ``` As paths in tests are very specific and wouldn't work for consumers, we can avoid packaging them.
kr8n3r
force-pushed
the
exclude-snapshot-folders-from-packages-and-dist
branch
from
4db9a98
to
44cb003
Compare
|
yeah, not related to the incident |
NickColley
approved these changes
Apr 19, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests that run after copy to
packagesordistthrow the following error:As paths in tests are very specific and wouldn't work for consumers, we can avoid packaging them.