Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error message and hint out of labels and legends #681

Merged
merged 25 commits into from May 10, 2018
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6215b41
Move error message out of label for input
36degrees Apr 25, 2018
c9c84f0
Move error message out of label for file upload
36degrees Apr 25, 2018
f41a653
Move error message out of label for textarea
36degrees Apr 25, 2018
79fb625
Move error message out of label for select
36degrees Apr 25, 2018
07dc99f
Remove error message from label
36degrees Apr 25, 2018
5f1c2c3
Move error message out of legend for checkboxes
36degrees May 1, 2018
64482a7
Move error message out of legend for radios
36degrees May 1, 2018
6448ff2
Move error message out of legend for date-input
alex-ju May 1, 2018
f992161
Remove error-message from fieldset
alex-ju May 1, 2018
e5317ea
Add hint component
alex-ju May 1, 2018
a87bf26
Remove hint from label
alex-ju May 2, 2018
1eaccc5
Move hint out of label for input
alex-ju May 2, 2018
d457ff7
Move hint out of label for file-upload
alex-ju May 2, 2018
85c7545
Move hint out of label for textarea
alex-ju May 2, 2018
07969f6
Move hint out of label for select
alex-ju May 2, 2018
93f4156
Remove hint from legend
alex-ju May 2, 2018
57e3b00
Move hint out of legend for checkboxes
alex-ju May 2, 2018
928cd3d
Move hint out of legend for radios
alex-ju May 2, 2018
c417fe1
Move hint out of legend for date-input
alex-ju May 2, 2018
572dedc
Fix helpers
alex-ju May 3, 2018
759fd5a
Override fieldset role to group for date input
36degrees May 9, 2018
01bb364
Add a11y criteria for hint and error message
36degrees May 9, 2018
e45b38b
Add tests for hint + error for fieldset components
36degrees May 9, 2018
c0d8f6f
Add tests for hint + error for labelled components
36degrees May 9, 2018
1f4bf3d
Add test for group role on date input fieldset
36degrees May 10, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/all/_all.scss
Expand Up @@ -13,6 +13,7 @@
@import "../fieldset/fieldset";
@import "../file-upload/file-upload";
@import "../footer/footer";
@import "../hint/hint";
@import "../input/input";
@import "../label/label";
@import "../panel/panel";
Expand Down