Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix body element rendering with no text #707

Merged
merged 3 commits into from
May 22, 2018
Merged

Fix body element rendering with no text #707

merged 3 commits into from
May 22, 2018

Conversation

NickColley
Copy link
Contributor

Fixes #558

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-707 May 21, 2018 17:07 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-707 May 21, 2018 17:08 Inactive
kr8n3r
kr8n3r reviewed May 21, 2018
View reviewed changes
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partly fixes #558 - the body bit
there will still be an issue with the titlehtml

@NickColley
Copy link
Contributor Author

titleHtml and titleText are both required params so I think it makes sense to always output them.

@kr8n3r
Copy link

kr8n3r commented May 22, 2018

yeah, what Dave is saying if you use titleHTML you can't there is no way to specify classes as we're rendering it inside a predefined class.
anywho, fixes main issus

@NickColley NickColley force-pushed the panel-dont-render-empty-div branch from 5f2f4c6 to 07b2438 Compare May 22, 2018 10:51
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-707 May 22, 2018 10:51 Inactive
@NickColley NickColley force-pushed the panel-dont-render-empty-div branch from 07b2438 to f573178 Compare May 22, 2018 10:52
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-707 May 22, 2018 10:52 Inactive
@NickColley NickColley force-pushed the panel-dont-render-empty-div branch from f573178 to a51af37 Compare May 22, 2018 17:26
@NickColley NickColley merged commit 914b00f into master May 22, 2018
@NickColley NickColley deleted the panel-dont-render-empty-div branch May 22, 2018 18:03
@alex-ju alex-ju mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickColley @kr8n3r @govuk-design-system-ci