Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boilerplate template #731

Merged
merged 13 commits into from
May 31, 2018
Merged

Add boilerplate template #731

merged 13 commits into from
May 31, 2018

Commits on May 31, 2018

  1. Add Boilerplate template 

    Changes from [govuk_template](https://github.com/alphagov/govuk_template):

Breaking changes:
- Removed stylesheets relating to `govuk_template.css`, we now recommend people bundle stylesheets in their application.
- Removed stylesheets relating to `print`, we do this at a component level.
- Removed stylesheets relating to `font`, we now have a [new font loading strategy](#726) that does not require a different bundle.
- Removed `ie8` specific class being added to the `html` element, since we don't require functionality
- Remove `ie.js`, used to shim HTML5 files, add JSON2 support, we now recommend people bundle in their application.

- Removed functionality to remove `js-enabled` class if `window.GOVUK` is not defined, at the moment we can't guarantee that this global will be set with GOV.UK Frontend.
See alphagov/govuk_template#248 for details on this feature.

Features:
- Added a main block, now skip link works by default, this block can be overridden.

Patch:
- Moved Skip link into it's own block, calling the [Skip link component](https://github.com/alphagov/govuk-frontend/tree/master/src/components/skip-link) by default instead of being inlined.
- Moved footer into it's own block, calling the [Footer component](https://github.com/alphagov/govuk-frontend/tree/master/src/components/footer) by default instead of being inlined.
- Moved header into it's own block, calling the [Header component](https://github.com/alphagov/govuk-frontend/tree/master/src/components/header) by default instead of being inlined.
- Changed the default `main` `id` to be `#main-content` to avoid being [styled by GOV.UK Elements](https://github.com/alphagov/govuk_elements/blob/8216538c1d2efb8b33372a22f28e1ea81d879ecd/assets/sass/elements/_layout.scss#L9).
    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    ce755c7 View commit details
    Browse the repository at this point in the history

  2. Use template.njk for the review application

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    2631e23 View commit details
    Browse the repository at this point in the history

  3. Add template example for review application

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    72adc7f View commit details
    Browse the repository at this point in the history

  4. Allow overriding of theme-color and icons in <head>

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    a11eb64 View commit details
    Browse the repository at this point in the history

  5. Add template areas page 

    Inspired by the GOV.UK Prototype Kit: https://govuk-prototype-kit.herokuapp.com/docs/examples/template-partial-areas

We may want to move this into the GOV.UK Design System website.
    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    cbd5f2a View commit details
    Browse the repository at this point in the history

  6. Remove redundant header footer example

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    132c8f7 View commit details
    Browse the repository at this point in the history

  7. Remove global from review application

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    51f3028 View commit details
    Browse the repository at this point in the history

  8. Add styles for template 

    This is consistent with the original GOV.UK Template approach.

- We need to reset default margins set by user-agents
- We need to set background-colors
    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    5924ed5 View commit details
    Browse the repository at this point in the history

  9. Update footer to use canvas background variable

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    b6bb23a View commit details
    Browse the repository at this point in the history

  10. Add tests for template 

    Also splits template example into two
    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    cccb7d3 View commit details
    Browse the repository at this point in the history

  11. Allow additional classes applied to the html element

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    c9331b5 View commit details
    Browse the repository at this point in the history

  12. Update CHANGELOG

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    4bb0f5d View commit details
    Browse the repository at this point in the history

  13. Ensure assets resolve from the domain root.

    @NickColley
    NickColley committed May 31, 2018
    Configuration menu
    Copy the full SHA
    ddf78a5 View commit details
    Browse the repository at this point in the history