Update JavaScript global namespace from 'all' to 'GOVUKFrontend' #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-747
This allows JavaScript to be accessed when not using a bundler. The pre-existing convention for JavaScript on GOV.UK uses `window.GOVUK`, to avoid conflicting with this we are using a different namespace.
NickColley
force-pushed
the
assign-govuk-frontend-javascript-global
branch
from
5d48db7
to
4789ed8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-747
alex-ju
approved these changes
Jun 1, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows JavaScript to be accessed when not using a bundler.
The pre-existing convention for JavaScript on GOV.UK uses
window.GOVUK, to avoid conflicting with this we are using a different namespace.Fixes #659