Document (non-contentious parts of) Sass settings layer #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refer to ‘font-families’ rather than ‘font-stacks’ throughout - Rename ‘govuk-nta-light’ to ‘govuk-font-family-nta’ - Add settings to groups in Sassdoc config - Make ‘actual’ settings !default
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-748
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-748
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-748
36degrees
changed the title
The fact that we’re using sass-mq is an implementation detail, so we shouldn’t expose it via our public API. This means wrapping their settings with our own settings, and trying to minimise its footprint throughout the app.
36degrees
changed the title
alex-ju
approved these changes
Jun 4, 2018
| @@ -115,7 +119,7 @@ describe('grid system', () => { | |||
| box-sizing: border-box; | |||
| width: 100%; | |||
| padding: 0 15px; } | |||
| @media (min-width: 46.25em) { | |||
| @media (min-width: 40.0625em) { | |||
There was a problem hiding this comment.
What's the reason behind the change of these values?
There was a problem hiding this comment.
Good question - it used to use the default sass-mq breakpoints, now it's using the ones defined in our settings.
There was a problem hiding this comment.
Could we add this to the PR comments?
|
this looks solid, happy to approve it now, but i guess others should have a look ( as they've been involved in the discussion) |
|
Argh, CHANGELOG. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in clarifying what comprises the public API of Frontend.
This adds Sassdocs for the following files:
settings/_assets.scsssettings/_colours-applied.scsssettings/_compatibility.scsssettings/_global-styles.scsssettings/_ie8.scsssettings/_measurements.scsssettings/_media-queries.scsssettings/_typography-font-families.scss(renamed from_typography-font-stacks.scss)settings/_typography-font.scssThat leaves some files in settings which are not using Sassdoc:
settings/_colours-organisations.scsssettings/_colours-palette.scsssettings/_spacing.scsssettings/_typography-responsive.scssI've left these (for now) because they all contain a large number of variables, and we've discussed moving them to maps and adding helper functions which will give us more control over e.g. deprecating colours.
As part of these changes we've also:
!defaultwhere it makes sense to do so$govuk-font-family-tabularfor tabular number mixins, rather than referencing nta-light-tabular directlysass-mq, and expose our own settings in our public apiThe media queries in the grid tests have changed because they used to use the default sass-mq breakpoints, and now they're using the ones defined in our settings.
https://trello.com/c/B8OCSU8R/759-agree-on-and-document-public-api-for-govuk-frontend