Avoid auto initialising initAll and export Components #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-759
|
does this require a change in our docs? |
NickColley
force-pushed
the
avoid-auto-initialising-components
branch
from
fc68175
to
657c703
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-759
|
@igloosi sorry, I got sidetracked, this now includes docs and changelog updates. |
Ensures the user is in control over when the JavaScript executes. Allows users to execute the components individually, from the browser bundle.
NickColley
force-pushed
the
avoid-auto-initialising-components
branch
from
657c703
to
9060290
Compare
|
Since documenting this way to include JavaScript is a bigger task I've raised an issue: #757 This is since I want to add docs on how to bring the build in from npm, similar to how we're doing it on the Prototype Kit. |
alex-ju
reviewed
Jun 4, 2018
| 'Radios' | ||
| ]) | ||
| }) | ||
| it('exported Components can be initialised', async () => { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the user is in control over when the JavaScript executes.
Allows users to execute the components individually, from the
browser bundle.