Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components' tables of arguments #769

Merged
merged 26 commits into from
Jun 13, 2018
Merged

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Jun 6, 2018

Ensuring table of arguments for each components is accurate.

Updates to index.njk and README.md files for each component.

Trello ticket: https://trello.com/c/rRQl78KY/1038-make-sure-all-component-argument-tables-are-accurate

For reviewers: Might be easiest to go through each component page on Github in the branch to check the rendered README file.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 6, 2018 14:42 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from 243bce9 to ee31937 Compare June 6, 2018 14:47
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 6, 2018 14:47 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from ee31937 to 6aae8fd Compare June 6, 2018 14:53
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 6, 2018 14:53 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from 6aae8fd to fb1dd7c Compare June 6, 2018 15:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 6, 2018 15:14 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 6, 2018 15:30 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 6, 2018 15:35 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from 4aed4b3 to 469ffdc Compare June 7, 2018 07:57
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 7, 2018 07:57 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from 469ffdc to 51c2cb7 Compare June 7, 2018 08:10
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 7, 2018 08:10 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 7, 2018 08:26 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from a410106 to ec469bf Compare June 8, 2018 13:26
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 8, 2018 13:27 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 8, 2018 13:51 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 8, 2018 15:30 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 8, 2018 15:34 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 08:27 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from 4e55d17 to 84a4a90 Compare June 11, 2018 08:35
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 08:35 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 08:41 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 08:46 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 08:55 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 12:39 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 13:02 Inactive
@kr8n3r kr8n3r force-pushed the update-tables-of-arguments branch from dfb0200 to 52c39f1 Compare June 11, 2018 13:37
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 11, 2018 13:37 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-769 June 12, 2018 08:07 Inactive
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@kr8n3r kr8n3r merged commit 45f539a into master Jun 13, 2018
@kr8n3r kr8n3r deleted the update-tables-of-arguments branch June 13, 2018 21:16
@hannalaakso hannalaakso mentioned this pull request Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants