Fix Design System url in package READMEs and review app #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-812
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-812
NickColley
suggested changes
Jun 21, 2018
There was a problem hiding this comment.
The vanity url only works for the root domain.
if you try to visit https://www.gov.uk/design-system/components/warning-text you'll see it fails.
We need to use the service domain whenever we are not referencing the root.
kr8n3r
force-pushed
the
fix-ds-url-in-package-readmes
branch
from
e025b2b
to
fa9e807
Compare
|
:( updated |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-812
NickColley
reviewed
Jun 21, 2018
| Description goes here (optional) | ||
|
|
||
| ([PR #N](https://github.com/alphagov/govuk-frontend/pull/N)) | ||
| - Fix Design System url in package READMEs and review app |
There was a problem hiding this comment.
I'd say this is an internal change really, it does get published via npm but isn't run in our user's applications.
kr8n3r
force-pushed
the
fix-ds-url-in-package-readmes
branch
from
fa9e807
to
d42f3bf
Compare
NickColley
approved these changes
Jun 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're currently pointing to *cloudapps.digital