Make radio and checkbox labels inline-block #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-821
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-821
|
@NickColley any idea why the labels were made |
|
IEs seem to be fine with inline-block |
|
Only thing I can think of is potential wrapping, with the conditional element, but maybe I just made a mistake. |
NickColley
reviewed
Jun 22, 2018
CHANGELOG.md
Outdated
| Description goes here (optional) | ||
|
|
||
| ([PR #N](https://github.com/alphagov/govuk-frontend/pull/N)) | ||
| - Make radio and checkbox labels `inline-block` instead of `block` |
There was a problem hiding this comment.
Can we reword this to explain what it fixes?
"Fixes radio and checkbox labels extending full width of page"
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-821
NickColley
approved these changes
Jun 25, 2018
added 2 commits
June 26, 2018 08:36
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #543 regression, reintroduced with conditional reveal.