Clean up package json #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-827
To try to help contributors or users understand that the root package.json is only used for development: - Adds description explaining the existance of `package/package.json` - Removes the fields related to issue trackers, homepages - Changes name to indicate it's not the npm package - Tidies up dependencies not being in devDependencies
- Lowers required Node.js version to former LTS 4.x, tested to work. - Adds keywords so it's easier to search
NickColley
force-pushed
the
clean-up-package-json
branch
from
edddf65
to
0dc4973
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-827
|
noice :) shall we wait with this one, get contributors in first so you can do the rebasing :) |
kr8n3r
approved these changes
Jun 25, 2018
kr8n3r
pushed a commit
that referenced
this pull request
Jun 26, 2018
In #827 we removed pinning teh node version, instead specifiying the minimum version. This resulted in Heroku failing as there is an error in the gulp taks in node 10.5.0 Heroku installs. Until we decide to upgrade to Gulp 4 we need to pin the version in package.json. Alternative option is to remove version entirely, although we want to set that for anyone wanting to contribute using `yarn` instead of `npm`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details
Closes #825