This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
Don't complain about block length in tests #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many test frameworks use blocks for the entire test case in a file as well as for individual tests within the file. It's not unusual for a test case to be several lines longer than the upper limit of the BlockLength cop, and there's very little we can do to avoid that so there's no point running this cop on our tests.
|
We also did this on government-frontend: |
floehopper
approved these changes
Sep 14, 2017
There was a problem hiding this comment.
We also did this in Asset Manager.
I had hoped that adding rubocop-rspec would fix this for RSpec specs, but I've just done some more investigation and it doesn't. And in any case, it would still leave the problem for non-RSpec tests.
Thus I reckon this should be merged.
This was referenced Sep 14, 2017
floehopper
added a commit
to alphagov/asset-manager
that referenced
this pull request
Sep 14, 2017
This is now taken care of by the `govuk-lint` gem itself [1]. [1]: alphagov/govuk-lint#82
fofr
added a commit
to alphagov/collections
that referenced
this pull request
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many test frameworks use blocks for the entire test case in a file as well as for individual tests within the file. It's not unusual for a test case to be several lines longer than the upper limit of the BlockLength cop, and there's very little we can do to avoid that so there's no point running this cop on our tests.
See: alphagov/support@4d5bcbc and alphagov/specialist-publisher@1991ab9 where I've done this in
.rubocop.ymlfor a couple of projects. There's bound to be more so this feels like something we should do in one place.