-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite README to incorporate versioning guidance #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the README so it's focussed on getting started with the app, as well as placing more emphasis on further documentation.
This is part of work to rewrite the "Pact Broker" dev doc [^1] so that it's focussed on writing tests, not details about this repo. [^1]: https://github.com/alphagov/govuk-developer-docs/blame/f8c7344ae79f333cd927cfb9ba30be2d2ee58fa4/source/manual/pact-broker.html.md#L54
benthorner
pushed a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Apr 22, 2022
This is very niche. alphagov/govuk-pact-broker#123
kevindew
reviewed
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, just a couple of suggestions.
benthorner
pushed a commit
that referenced
this pull request
Apr 27, 2022
In response to [^1]. [^1]: #123 (comment)
ChrisBAshton
reviewed
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for all the comments - the perils of markdown split over hard newlines!
In response to [^1]. [^1]: #123 (comment)
kevindew
approved these changes
May 5, 2022
ChrisBAshton
approved these changes
May 6, 2022
benthorner
pushed a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
May 17, 2022
This is very niche. alphagov/govuk-pact-broker#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/fRihmgQ8/266-add-top-level-guidance-about-where-we-write-tests-on-govuk
This tidies up the README a bit to provide a structure
for adding further guidance about the versioning scheme
used by this fork of Pact Broker.
Please see the commits for more details.