Fix GOV.UK Frontend initAll() on management pages
#2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By loading `kit.js` first this ensures `window.GOVUKPrototypeKit` is available when initialising GOV.UK Frontend
BenSurgisonGDS
previously approved these changes
Sep 26, 2023
BenSurgisonGDS
previously approved these changes
Sep 26, 2023
colinrotherham
force-pushed
the
frontend-init
branch
from
1a1bb83
to
d89a7f1
Compare
BenSurgisonGDS
approved these changes
Sep 26, 2023
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On management pages,
window.GOVUKPrototypeKitis unavailable when GOV.UK Frontendinit.jsrunsThis PR loads
kit.jsfirst to ensurewindow.GOVUKPrototypeKitis availableFixes #2348