-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GOV.UK Frontend v5 plugin #2293
Comments
3 tasks
I've update the description to include all known remaining tasks |
Just an update to track progress a little better The following changes were made by the Prototype Kit team:
With support fixes contributed by GOV.UK Frontend:
But with extra backwards compatibility considerations from GOV.UK Frontend too: |
I think this one is done now? Management pages will be updated in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
GOV.UK Frontend v5 changes must be handled by the Prototype Kit to prevent broken prototypes and support issues
To reduce impact on the team, management and error pages should stay on GOV.UK Frontend v4 for now
We also have various package files using
$legacy
parameters now deprecated in GOV.UK Frontend v5. We should suppress these deprecation warnings until the following files can be updated:govuk-prototype-kit/lib/assets/sass/patterns/_pagination.scss
govuk-prototype-kit-step-by-step/sass/_step-by-step-navigation.scss
govuk-prototype-kit-step-by-step/sass/_step-by-step-navigation-header.scss
Why
GOV.UK Frontend v5 is a breaking change due to:
<script>
to<script type="module">
The legacy palette was replaced in GOV.UK Frontend v3.0.0:
https://designnotes.blog.gov.uk/2019/07/29/weve-updated-the-gov-uk-colours-and-font/
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
<script type="module">
plugin scripts$legacy
deprecated colour paletteapplication.js
to load after plugin scriptsThe text was updated successfully, but these errors were encountered: