Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GOV.UK Frontend v5 plugin #2293

Closed
4 tasks done
nataliecarey opened this issue Aug 15, 2023 · 3 comments · Fixed by #2306
Closed
4 tasks done

Support GOV.UK Frontend v5 plugin #2293

nataliecarey opened this issue Aug 15, 2023 · 3 comments · Fixed by #2306

Comments

@nataliecarey
Copy link
Contributor

nataliecarey commented Aug 15, 2023

What

GOV.UK Frontend v5 changes must be handled by the Prototype Kit to prevent broken prototypes and support issues

A test version (or pre-release) will be ready for teams to test at the end of October 2023. This gives us an opportunity to receive feedback and make necessary changes before a full release. We expect that the full release will be ready between November and December 2023.

To reduce impact on the team, management and error pages should stay on GOV.UK Frontend v4 for now

We also have various package files using $legacy parameters now deprecated in GOV.UK Frontend v5. We should suppress these deprecation warnings until the following files can be updated:

  • govuk-prototype-kit/lib/assets/sass/patterns/_pagination.scss
  • govuk-prototype-kit-step-by-step/sass/_step-by-step-navigation.scss
  • govuk-prototype-kit-step-by-step/sass/_step-by-step-navigation-header.scss

Why

GOV.UK Frontend v5 is a breaking change due to:

  1. Compiled assets, fonts, views, scripts, stylesheets moving into child directory
  2. JavaScript includes switching from <script> to <script type="module">
  3. Legacy colour palette is now deprecated

The legacy palette was replaced in GOV.UK Frontend v3.0.0:
https://designnotes.blog.gov.uk/2019/07/29/weve-updated-the-gov-uk-colours-and-font/

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Update management and error pages to use only "internal" GOV.UK Frontend
  • Support added for <script type="module"> plugin scripts
  • Suppress Sass warnings for $legacy deprecated colour palette
  • Defer prototype application.js to load after plugin scripts
@colinrotherham colinrotherham changed the title Support GOV.UK Frontend v5 Support GOV.UK Frontend v5 plugin Oct 9, 2023
@colinrotherham
Copy link
Contributor

I've update the description to include all known remaining tasks

@colinrotherham
Copy link
Contributor

I think this one is done now? Management pages will be updated in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants