Suppress Sass warnings for $legacy deprecated colour palette
#2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
changed the title
$legacy deprecation warnings$legacy deprecated colour palette
This was referenced Oct 9, 2023
colinrotherham
force-pushed
the
frontend-v5-deprecated
branch
from
da0b09f
to
bbf1687
Compare
BenSurgisonGDS
previously approved these changes
Oct 9, 2023
colinrotherham
force-pushed
the
nunjucks-env
branch
from
99492e1
to
4781c10
Compare
We have various package files using `$legacy` parameters now deprecated in GOV.UK Frontend v5 We should suppress these deprecation warnings until the following files can be updated: * `govuk-prototype-kit/lib/assets/sass/patterns/_pagination.scss` * `govuk-prototype-kit-step-by-step/sass/_step-by-step-navigation.scss` * `govuk-prototype-kit-step-by-step/sass/_step-by-step-navigation-header.scss`
colinrotherham
force-pushed
the
frontend-v5-deprecated
branch
from
bbf1687
to
d598993
Compare
|
Moved the CHANGELOG entry into Unreleased |
nataliecarey
previously approved these changes
Oct 10, 2023
colinrotherham
dismissed stale reviews from nataliecarey and BenSurgisonGDS
The base branch was changed.
BenSurgisonGDS
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses Sass
$legacycolour palette deprecation warnings logged by GOV.UK Frontend v5 until the following files and packages can be updated from issue #2293:This completes GOV.UK Frontend v5 plugin support in #2293
Legacy colour palette
The legacy palette was replaced in GOV.UK Frontend v3.0.0:
https://designnotes.blog.gov.uk/2019/07/29/weve-updated-the-gov-uk-colours-and-font/
Support has continued throughout v4.0.0 but is deprecated in v5.0.0