This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Enable sass linting by default, as had been expected #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If `options.sassLint` is omitted it is null and falsy. * The default state was therefore no sass linting * Explicitly check that it has been set to false so that if the option is not provided sassLint runs
|
Related to alphagov/government-frontend#402 |
|
This seems good to me, but maybe @suzannehamilton has other ideas on how to set defaults in the options? |
suzannehamilton
approved these changes
Jul 19, 2017
|
Because we lint all SASS, when we merge this there will be build failures on unrelated PRs, there may be some clean-up required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: I don't know groovy and I am unsure how to test this. Help would be much appreciated.
The docs say that the sass linter is on by default:
govuk-puppet/modules/govuk_jenkins/files/var/lib/jenkins/groovy_scripts/govuk_jenkinslib.groovy
Line 55 in f28348c
That's not the case though.
options.sassLintis omitted then checkingoptions.sassLintis null and falsy.I think this may have broken here:
#5828