Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak bootstrap-sass pin and navbar logic #116

Merged
merged 3 commits into from Jan 4, 2016
Merged

Tweak bootstrap-sass pin and navbar logic #116

merged 3 commits into from Jan 4, 2016

Commits on Dec 31, 2015

  1. Pin to 3.3.5.1 

    Use 3.3.5.1 rather than 3.3.5 as this contains a necessary Sass
dependency fix:
https://rubygems.org/gems/bootstrap-sass/versions/3.3.5.1

Pinning because bootstrap-sass has a tendency to release breaking
changes in point releases.
    @fofr
    fofr committed Dec 31, 2015
    Copy the full SHA
    ef10e0b View commit details
    Browse the repository at this point in the history

  2. Move navbar logic into variable 

    Clarify which bits are dependent on navbar content being present.

Fixes a bug where the collapsed nav icon wouldn’t shown when there are
no navbar items but there is a sign out link.
    @fofr
    fofr committed Dec 31, 2015
    Copy the full SHA
    a75bbee View commit details
    Browse the repository at this point in the history

  3. Add comment to example about setting in config

    @fofr
    fofr committed Dec 31, 2015
    Copy the full SHA
    e00bf3a View commit details
    Browse the repository at this point in the history