Remove multivariate test javascript #420
Merged
Conversation
|
Sounds good to me. |
* The multivariate test framework dynamically updates page content after the page has loaded to show variants to users which are tracked to GA * GOV.UK is the main user of this and have created a server-side alternative An example of a test that was created in an inaccessible way: alphagov/frontend#1228 (review) 4
|
This sounds good to me @fofr ! When merged please update the manual page on A/B tests here: https://docs.publishing.service.gov.uk/manual/ab-testing.html |
|
Let me check with Polly on the content team about when this AB test should end cc\ @fofr @nickcolley |
fofr
changed the title
fofr
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Jun 27, 2017
Multivariate testing using JS is being deprecated in govuk_frontend_toolkit: alphagov/govuk_frontend_toolkit#420 This avoids the risk of developers creating AB tests that are not accessible.
|
AB test documentation updated here: alphagov/govuk-developer-docs#292 |
fofr
added a commit
that referenced
this pull request
Jun 29, 2017
Remove multivariate test library PR #420.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
GOV.UK now has an alternative AB testing strategy which is server side. A server side approach prevents flashes of content. Deleting this logic will reduce the risk of creating tests that might be inaccessible, such as this: alphagov/frontend#1228 (review)
Even when no tests are running, GOV.UK includes this JS on every page:
https://github.com/alphagov/static/blob/master/app/assets/javascripts/application.js#L4
After discussion with @nickcolley, on the belief that this has mainly been used by GOV.UK, we think this library could be removed. It would be a breaking change with a major version bump. Apps that still require the tests could copy the javascript across.
cc @carvil @alecgibson