Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multivariate test javascript #420

Merged
merged 1 commit into from Jun 28, 2017
Merged

Remove multivariate test javascript #420

merged 1 commit into from Jun 28, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 20, 2017

GOV.UK now has an alternative AB testing strategy which is server side. A server side approach prevents flashes of content. Deleting this logic will reduce the risk of creating tests that might be inaccessible, such as this: alphagov/frontend#1228 (review)

Even when no tests are running, GOV.UK includes this JS on every page:
https://github.com/alphagov/static/blob/master/app/assets/javascripts/application.js#L4

After discussion with @nickcolley, on the belief that this has mainly been used by GOV.UK, we think this library could be removed. It would be a breaking change with a major version bump. Apps that still require the tests could copy the javascript across.

cc @carvil @alecgibson

Copy link

@tvararu tvararu left a comment

Sounds good to me. 👍

* The multivariate test framework dynamically updates page content
after the page has loaded to show variants to users which are tracked
to GA
* GOV.UK is the main user of this and have created a server-side
alternative

An example of a test that was created in an inaccessible way:
alphagov/frontend#1228 (review)
4
@fofr fofr force-pushed the remove-multivariate-js branch from 86f1122 to 89a16ad Jun 20, 2017
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 21, 2017

@carvil
Copy link
Contributor

@carvil carvil commented Jun 23, 2017

This sounds good to me @fofr ! When merged please update the manual page on A/B tests here: https://docs.publishing.service.gov.uk/manual/ab-testing.html

@ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala commented Jun 23, 2017

Let me check with Polly on the content team about when this AB test should end cc\ @fofr @nickcolley

@fofr fofr changed the title [Discuss] Remove multivariate test javascript Remove multivariate test javascript Jun 27, 2017
fofr added a commit to alphagov/govuk-developer-docs that referenced this pull request Jun 27, 2017
Multivariate testing using JS is being deprecated in
govuk_frontend_toolkit:
alphagov/govuk_frontend_toolkit#420

This avoids the risk of developers creating AB tests that are not
accessible.
@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 27, 2017

AB test documentation updated here: alphagov/govuk-developer-docs#292

@fofr fofr merged commit b628fc5 into master Jun 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr deleted the remove-multivariate-js branch Jun 28, 2017
fofr added a commit that referenced this pull request Jun 29, 2017
Remove multivariate test library PR #420.
@fofr fofr mentioned this pull request Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.