Fix branding

Moves the branding class to the document list item instead of the ul which may not always be rendered.
alphagov · Aug 14, 2018 · 0bbe2e1 · 0bbe2e1
1 parent adb1084
commit 0bbe2e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/views/govuk_publishing_components/components/_document_list.html.erb b/app/views/govuk_publishing_components/components/_document_list.html.erb
@@ -11,10 +11,10 @@
 %>
 <% if items.any? %>
   <% unless within_multitype_list %>
-    <ol class="gem-c-document-list<%= margin_bottom_class %><%= margin_top_class %> <%= brand_helper.brand_class %>">
+    <ol class="gem-c-document-list<%= margin_bottom_class %><%= margin_top_class %>">
   <% end %>
     <% items.each do |item| %>
-      <li class="gem-c-document-list__item<%= within_multitype_list_class %>">
+      <li class="gem-c-document-list__item<%= within_multitype_list_class %> <%= brand_helper.brand_class %>">
         <%=
           link_to(
             item[:link][:text],

diff --git a/spec/components/document_list_spec.rb b/spec/components/document_list_spec.rb
@@ -149,7 +149,7 @@ def component_name
       ]
     )
 
-    assert_select '.gem-c-document-list.brand--attorney-generals-office'
+    assert_select '.gem-c-document-list__item.brand--attorney-generals-office'
     assert_select '.gem-c-document-list .gem-c-document-list__item-title.brand__color'
   end