-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add margin spacing to document list #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require the document list component to have top and bottom margins around it on topic pages. This commit allows us to set margin_bottom and margin_top flags to set this spacing.
vanitabarrett
force-pushed
the
add-spacing-document-list
branch
from
March 13, 2018 15:41
31ab9a6
to
f9dd687
Compare
vanitabarrett
force-pushed
the
add-spacing-document-list
branch
from
March 13, 2018 15:42
f9dd687
to
65f55c3
Compare
leenagupte
approved these changes
Mar 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
maxgds
approved these changes
Mar 14, 2018
Merged
This was referenced Mar 15, 2018
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require the document list component to have top and bottom margins around it on topic pages. This commit allows us to set
margin_bottom
andmargin_top
flags to set this spacing.