Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin spacing to document list #217

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Mar 13, 2018

We require the document list component to have top and bottom margins around it on topic pages. This commit allows us to set margin_bottom and margin_top flags to set this spacing.

screen shot 2018-03-13 at 15 34 37

@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-217 March 13, 2018 15:35 Inactive
We require the document list component to have top and bottom margins around it on topic pages. This commit allows us to set margin_bottom and margin_top flags to set this spacing.
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@vanitabarrett vanitabarrett merged commit 359dee4 into master Mar 14, 2018
@vanitabarrett vanitabarrett deleted the add-spacing-document-list branch March 14, 2018 09:38
@vanitabarrett vanitabarrett mentioned this pull request Mar 14, 2018
This was referenced Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants