Fix related navigation component bugs #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worldwide Organisations shouldn't be displayed in the related nav, so we remove this from the helper.
We found a bug whereby grandparent mainstream browse pages weren't being added to the "topics" part of the `related_navigation` payload. This updates a couple of methods where the content item's keys weren't being handled correctly and adds a test to check for the presence of parent and grandparent mainstream browse pages.
emmabeynon
force-pushed
the
tidy-up-related-navigation
branch
from
8208e49
to
9e5f34d
Compare
vanitabarrett
approved these changes
Mar 9, 2018
steventux
suggested changes
Mar 9, 2018
There was a problem hiding this comment.
This looks good to me, however the heroku build is failing on:
Bundler Output: Warning: the running version of Bundler (1.15.2) is older than the version that created the lockfile (1.16.1). We suggest you upgrade to the latest version of Bundler by running `gem install bundler`.
You are trying to install in deployment mode after changing
your Gemfile. Run `bundle install` elsewhere and add the
updated Gemfile.lock to version control.
The gemspecs for path gems changed
!
! Failed to install gems via Bundler.
!
! Push rejected, failed to compile Ruby app.
! Push failed
I'm not sure what has messed with Gemfile.lock but we either need to fix in another PR, merge and rebase, or tack a commit here to fix it.
|
@steventux I've got some other PR's open here which I got to build by adding I think it must have been missing in a previous commit that's now been merged? |
|
@vanitabarrett 👍 so a rebase should fix the issue? |
steventux
approved these changes
Mar 9, 2018
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://trello.com/c/nGtzTPCu/283-update-government-frontend-to-use-relatednavigation-component
While implementing the
related_navigationcomponent in government-frontend we found a couple of bugs, which this PR addresses: