Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single page notification button data attributes for tracking #2471

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Fix single page notification button data attributes for tracking #2471

merged 3 commits into from
Nov 25, 2021

Commits on Nov 25, 2021

  1. Fix single page notification button data attrs 

    The data attributes for tracking are not named correctly. data-label
should be data-track-label, data-action should be data-track-action,
data-category should be data-track-category.
    @danacotoran
    danacotoran committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    5789c5a View commit details
    Browse the repository at this point in the history

  2. update CHANGELOG

    @danacotoran
    danacotoran committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6495067 View commit details
    Browse the repository at this point in the history

  3. Apply track click attribute to wrapper 

    Apply the data-module="gem-track-click" for the single page notification
button to a component wrapper div.
The reason behind applying this to a wrapper and not to the form is that
the form gets swapped out with the form returned from the
personalisation endpoint, so the track click module would have to be
re-started on the new, updated form.
Applying the track-click attribute to a wrapper instead means we don't
have to re-start the gem-track-click module for the updated form.
    @danacotoran
    danacotoran committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    2dc71b5 View commit details
    Browse the repository at this point in the history