Fix error in LUX script #3592
Merged
Fix error in LUX script #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to reproduce, clear cookies, reload page then accept cookies, error of `Uncaught TypeError: Cannot read properties of null (reading 'pop')` will occur - this refers to the `getCustomerId()` function, which if `LUX.customerid` is not defined will attempt to determine it from the source URL of the LUX script, something like `lux.js?id=1234` - we don't get our customerid this way, instead we hard code it into this file, because we host our own copy of the LUX script (see the documentation for more detail and background on this), so the script failed, because there was nothing to find - instead we remove this part of the `getCustomerId()` function and simply return `LUX.customerid`. We also now need to set this inside the LUX object itself, because otherwise it isn't set properly in the steps described above - documentation updated to reflect this for future updates
AshGDS
approved these changes
Sep 6, 2023
Merged
andysellick
added a commit
that referenced
this pull request
Oct 19, 2023
- some things changed recently, including #3592
andysellick
added a commit
that referenced
this pull request
Oct 19, 2023
- some things changed recently, including #3592
andysellick
added a commit
that referenced
this pull request
Oct 19, 2023
- some things changed recently, including #3592
andysellick
added a commit
that referenced
this pull request
Oct 19, 2023
- some things changed recently, including #3592
andysellick
added a commit
that referenced
this pull request
Oct 19, 2023
- some things changed recently, including #3592
andysellick
added a commit
that referenced
this pull request
Oct 20, 2023
- some things changed recently, including #3592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix an error in the live real user monitoring script relating to the unusual way in which we use this script.
Uncaught TypeError: Cannot read properties of null (reading 'pop')will occurgetCustomerId()function, which ifLUX.customeridis not defined will attempt to determine it from the source URL of the LUX script, something likelux.js?id=1234getCustomerId()function and simply returnLUX.customerid. We also now need to set this inside the LUX object itself, because otherwise it isn't set properly in the steps described aboveWhy
Was causing an error on the live site. This is bad.
Visual Changes
None.