WIP drop JS support for IE #3996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to type="module" - remove polyfills - remove references to polyfills - check for possible need for extra semi-colons (was just trying this, not sure it helped)
AshGDS
force-pushed
the
remove-gradex-support
branch
from
acb643c
to
d0e86ed
Compare
Broke the styles though due to v5 upgrade
|
@andysellick I think the issues you were having were due to using an old version of govuk-frontend, and I hackily got the JS to work now by upgrading to V5, but at the expense of the styles breaking. I think the old version of govuk-frontend was coupled to our Polyfills. Therefore it might be worth basing the spike off the work already done in #3700 |
|
Superseeded by #4000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Work in progress spike switching over to using
type="module"for scripts, so that IE11 and below don't run any of our JavaScript. Needs some accompanying changes in bothstaticand the application being rendered. Currently getting weird JS errors likeapplication.js:367 Uncaught TypeError: Cannot read properties of undefined (reading 'GOVUKFrontend'), which looks more like a bundling error than an actual problem.Why
alphagov/govuk-rfcs#171
Visual Changes
@AshGDS