Enable bold text in govspeak #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
changed the title
tijmenb
reviewed
Aug 1, 2018
There was a problem hiding this comment.
This is going to need a lot of description in the PR, since the change is likely to be controversial and will be referenced a lot.
As for the code, we also need to remove the entire rich_govspeak feature. That means removing the param, examples from the YAML file, and remove the param from any existing page that uses it.
This was referenced Aug 3, 2018
Certain types of guidance have tested positively with inline bold text (eg. https://www.gov.uk/guidance/connect-to-govwifi-using-an-android-device) Instead of enabling bold text as by exception we'd like to see the effect of enabling entirely. If nothing else it's good to talk through why this is a good or bad idea and what the effect of permitting bold text has and will be on content managed text.
Bold text has been enabled in govspeak so the rich-govspeak styles can be removed along with the component options.
steventux
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/BUij6N3Y/361-turn-on-bold-for-whitehall
Do not merge because we'd like to see how this works in various formats in a preview app.
We've been asked to enable bold text for a specific format which tested favourably.
(eg. https://www.gov.uk/guidance/connect-to-govwifi-using-an-android-device)
Instead of enabling bold text by exception this PR enables it entirely for govspeak text containing
<strong>tags.Component guide for this PR:
https://govuk-publishing-compon-pr-463.herokuapp.com/component-guide/