Add data-attribute support to input #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-ju should I see something following the link to the component guide? I just get
|
|
@davbo: yep, seems that Heroku preview app is not working. I would check to see why, but I don't have access. |
alex-ju
force-pushed
the
update-input-component
branch
from
7d2c060
to
a44f68a
Compare
alex-ju
force-pushed
the
update-input-component
branch
from
a44f68a
to
fbfdc2e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to the input component:
data-module; analytics tracking - e.g.data-track)Component guide for this PR:
https://govuk-publishing-compon-pr-469.herokuapp.com/component-guide/input