Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SassC Rails #853

Merged
merged 1 commit into from
May 14, 2019
Merged

Update to SassC Rails #853

merged 1 commit into from
May 14, 2019

Conversation

injms
Copy link
Contributor

@injms injms commented May 13, 2019

Ruby Sass is deprecated so needs to be replaced with something that is supported. SassC Rails is faster and a drop in replacement, according to its readme, and it seems to be both of these.

Fixes #601.

Trello ticket.

A drop in replacement, according to the
[SassC Rails docs](https://github.com/sass/sassc-rails), and it seems to
be.
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

Looks good. My local's still warning that Ruby Sass is deprecated, but I assume that's an automatic message? Any way of getting rid of that?

@andysellick
Copy link
Contributor

@injms also if this is faster, can we get this in finder-frontend too?

@injms injms removed the request for review from alex-ju May 14, 2019 07:21
@injms
Copy link
Contributor Author

injms commented May 14, 2019

🎉 🎉 🎉

Looks good. My local's still warning that Ruby Sass is deprecated, but I assume that's an automatic message? Any way of getting rid of that?

The Ruby Sass looks to be included because of the deprecated govuk_frontend_toolkit - I thought it best to replace that as a separate task.

@injms injms merged commit 3f9c261 into master May 14, 2019
@injms injms deleted the update-sass-build-process branch May 14, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from sass to sassc (and libsass)
3 participants