Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flappy content schema test #789

Closed
mcgoooo opened this issue Jan 18, 2017 · 2 comments · Fixed by #790
Closed

flappy content schema test #789

mcgoooo opened this issue Jan 18, 2017 · 2 comments · Fixed by #790

Comments

@mcgoooo
Copy link

mcgoooo commented Jan 18, 2017

Hey,

just putting a note in for this.

there seems to be some flaky tests in the manuals publisher that get triggered when you update content schema, looking through the builds it seems to be a common flaky test
h-lame added a commit that referenced this issue Jan 19, 2017
@h-lame
Fixes flappy test for manual_publication_log_filter_spec
82000cb 
Turns out the previous fixes in #783 weren't enough - although we'd
identified that the ordering was the problem, it wasn't the dates that
were the problem.  The test asks for the publication logs to be ordered
by id, but this does nothing.  Although id is a method on a mongoid object
that does indeed return the id of the object, the db field is actually
called `_id`. Asking to sort by `id` does nothing, which means we get
things back in an indeterminate order.

Asking to sort by `_id` gets the data in the expected order and the test
consistently passes (or so it seems anyway).

fixes #789
@h-lame h-lame mentioned this issue Jan 19, 2017
Merged
@mcgoooo
Copy link
Author

mcgoooo commented Jan 19, 2017 •
edited
Loading

we owe you a 🍺 😄

@h-lame
Copy link
Contributor

h-lame commented Jan 19, 2017 •
edited
Loading

Well, my commit message does say "...and the test consistently passes (or so it seems anyway)." so maybe give it a while to be sure. 😉

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes flappy test for manual_publication_log_filter_spec alphagov/manuals-publisher
2 participants
@h-lame @mcgoooo