Remove ManualRelocator #878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last reference to this class was removed in f8698ce. It is mentioned in #851 as a recent example of useful script that has tests so we may want to use it in the future to base a similar migration on. But for now it cannot be used externally via a script or rake task so I think it is safe to remove it.
|
You might want to keep this around - it's a complicated task and used specifically in response to support queries that come in. Responding to support queries may not always be dealt with by committed scripts (although they probably should be). |
|
Thanks for pointing that out @h-lame - if this is still used, I might add and document a small script in |
chrisroos
added a commit
that referenced
this pull request
Apr 28, 2017
I don't fully understand the use case for this script but we've agreed to wrap it in a Rake task to prevent us from removing it in future. We tried to remove it in PR #878 but @h-lame pointed out that it might still be useful for certain support requests that come in. Note that commit 21fcb3f changed the behaviour of this utility so that both manuals had to be published before you could move one to the other. This seems slightly confusing to me as I think it means that the script essentially overwrites one manual with the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last reference to this class was removed in f8698ce. It is
mentioned in #851 as a recent example of useful script that has tests
so we may want to use it in the future to base a similar migration
on. But for now it cannot be used externally via a script or rake task
so I think it is safe to remove it.