This repository has been archived by the owner on Feb 13, 2018. It is now read-only.
Add new feed and mail link design #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.1kb down to 500 bytes
* Clean up small screen view * Better align icons against text baseline * Update copy, users were clicking “email” thinking they could email someone * Don’t use h1 for subscriptions, fixes hierarchy * Remove title attributes from links now text is longer and self-explanatory
fofr
changed the title
|
I think we can simplify the CSS to rely on the flow of the content rather than using a media query. This would mean the content determines if it will stack, which does not happen on most viewports. .subscriptions {
@include bold-19;
ul {
list-style: none;
margin-left: -$gutter-half / 2;
margin-right: -$gutter-half / 2;
}
li {
display: inline-block;
margin-left: $gutter-half / 2;
margin-right: $gutter-half / 2;
margin-bottom: $gutter / 2;
}
a {
text-decoration: none;
padding-left: 28px;
background-repeat: no-repeat;
background-position: 0 20%;
@include media(tablet) {
background-position: 0 35%;
}
}
}Then remove the padding-bottom from Otherwise this is looking great 👍 , more accessible since we're removing the |
|
@NickColley Updated in 22362f2 |
* Remove need for media queries * Let content wrap naturally and always be styled correctly * Uses space better Based on feedback from @NickColley
fofr
force-pushed
the
tweak-email-feed-links
branch
from
22362f2
to
470f962
Compare
|
Okay I've tested this on IE8+, iOS and Android, looking good. 👍 |
NickColley
approved these changes
Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/KtX7L1Md/514-travel-advice-publisher-multi-page-front-end-edit-email-alert-link-text-1
someone
self-explanatory
Wide viewport
Thin viewport