Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tour for users new to broadcast services #3547

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

quis
Copy link
Member

@quis quis commented Aug 3, 2020

This is an initial, prototype-quality attempt at introducing some kind of tour for users new to broadcasting. A lot of the users we’re speaking to don’t have a good concept of what broadcasting means, which is causing usability problems down the line.

We did a similar thing in the early days of Notify to explain the concept of message templates and personalisation.

image

image

image

image

Comment on lines +43 to +45
service = Service.from_id(invited_user.service)
if service.has_permission('broadcast'):
return redirect(url_for('main.broadcast_tour', service_id=service.id, step_index=1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is enough for "my existing user has been invited to a new broadcast service, and i should be told how broadcasting works"

this code will, i believe, be called if someone clicks on an invite link which has already been accepted. it then bounces to service_dashboard, which will either show succesfully if the correct user is signed in, or bounce again to sign-in if the user isn't signed in.

not sure if its useful to have this here, though i don't hate it being here. however, i think we also need to add it ten lines below in the existing_user block:

    if existing_user:
        invited_user.accept_invite()
        [....]
        return redirect(url_for('main.service_dashboard', service_id=service.id))

if the user doesn't already exist, then they'll get scooped up by verify.py so thats good 👍

This is an initial, prototype-quality attempt at introducing some kind
of tour for users new to broadcasting. A lot of the users we’re speaking
to don’t have a good concept of what broadcasting means, which is
causing usability problems down the line.

We did a similar thing in the early days of Notify to explain the
concept of message templates and personalisation.
@quis quis merged commit 4bf4680 into master Aug 3, 2020
@quis quis deleted the broadcast-tour branch August 6, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants